Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing checks exporting #9034

Merged
merged 2 commits into from May 26, 2020

Conversation

thiagoftsm
Copy link
Contributor

Summary

This PR brings the missing tests to returns for uv_ functions as specified at #8461.

Component Name

Exporting

Test Plan

1 - Start hbase
2 - Start zookeper
3 - Start opentsdb running: ./tsdb tsd --port=4242 --staticroot=staticroot/ --cachedir=/tmp/tsd --zkquorum=localhost:2181 --auto-metric
4 - Start JSON backend running: nc -lntp 5448
5 - Start MongoDB: The command here depends of the distribution.
6 - Configure exporting.conf:

[exporting:global]
    enabled = yes
    send configured labels = yes
    send automatic labels = no

[json:my_instance]
    enabled = yes
    destination = localhost:5448

[opentsdb:http:my_instance2]
    enabled = yes
    destination = localhost:4242

[mongodb:instanceA]
    enabled = yes
    destination = mongodb://localhost
    database = netdata
    collection = instanceA

@vlvkobal , please, update the example bringing the options for AWS.

7 - Start Netdata
8 - Verify all the exporters received the data.

Additional Information

This PR does not brings everything listed on #8461 and it is not a blocker for any other action there.

@squash-labs
Copy link

squash-labs bot commented May 14, 2020

Manage this branch in Squash

Test this branch here: https://thiagoftsmmissing-checks-expor-r48jc.squash.io

vlvkobal
vlvkobal previously approved these changes May 25, 2020
@thiagoftsm thiagoftsm requested a review from stelfrag May 25, 2020 11:59
stelfrag
stelfrag previously approved these changes May 26, 2020
This commit brings tests to uv_mutex_init like it was tested on mongodb.c
Brings test to uv_cond_init
@thiagoftsm thiagoftsm merged commit 605705a into netdata:master May 26, 2020
@thiagoftsm thiagoftsm deleted the missing_checks_exporting branch May 26, 2020 18:23
Saruspete pushed a commit to Saruspete/netdata that referenced this pull request Jun 17, 2020
Add tests to uv_mutex_init and uv_cond_init inside exporting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants