Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor core/baseline() to handle multiple targets. #61

Closed
forestmonster opened this issue May 22, 2019 · 0 comments
Closed

Refactor core/baseline() to handle multiple targets. #61

forestmonster opened this issue May 22, 2019 · 0 comments
Assignees

Comments

@forestmonster
Copy link
Contributor

When creating a baseline, additional targets are ignored (https://github.com/Netflix-Skunkworks/diffy/blob/master/diffy/core.py#L72). However, some TargetPlugin derivatives will submit multiple targets. We should be able to set a dictionary key in target_plugin["options"] indicating multiple targets, pass that using **kwargs, and add decision logic in core.py that acts on multiple or single targets based on the value.

@forestmonster forestmonster self-assigned this May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant