-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users should be able to set notification interval expiration #8
Comments
Context -- we renew at 14 days and alert at 10. |
@andrewachen what granularity were you thinking? Is specifying an arbitrary number of days before notification enough? Would a numeric and a unit useful? (1d, 1w, 1m, 1yr) |
Yes, numeric and a unit would be useful. For my use case, I'd be interested in alerting at 7d and 3d. We also need the ability to acknowledge/mute an alert. For example, when we retire a site, I want to be able to manually squelch notifications for its certs. |
Okay, this will most likely change the /certificate api adding a new optional value of 'notifications'. This would be a list of notifications that are associated with the newly created certificate. These notifications would be defined before hand and could be general or team specific. Think - my_team_notification_14_days, with a few recipients of the notification. Certificates already have an 'active' flag, when marked as 'inactive' this will mute all associated notifications for that particular certificate. Would this API addition warrant an API increment? Since it's optional I would think that this could be added without breaking any existing code. I am hoping to have something for this this week. |
I say it's not necessary to increment the version if it's a new optional field (as opposed to changing an existing field or making it required). My general rule of thumb is if existing code in the wild will continue to work after my API change, then no need to rev the api. |
…rt before adding it from EJBCA
merging commits from netflix/lemur master
Lemur notifies users about certificate expiration 30, 15, 10, 5, 1 days before expiration. We should allow users to configure this interval.
The text was updated successfully, but these errors were encountered: