Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with Kubeflow pipelines #25

Closed
BAlmeidaS opened this issue Dec 5, 2019 · 10 comments
Closed

Integration with Kubeflow pipelines #25

BAlmeidaS opened this issue Dec 5, 2019 · 10 comments
Labels
enhancement New feature or request

Comments

@BAlmeidaS
Copy link

First things first, thanks to open this project!! We are working in a very similar project, and Metaflow is going to help us a lot.

Do you plan to create a kind of integration with Kubeflow Pipelines? For us, this is very helpful to deploy these pipelines in our production environment.

@SteNicholas
Copy link

@BAlmeidaS I mentioned this integration with kubeflow in issue Support for Airflow and Kubernetescomment. I really thought that metaflow integration with kubeflow reduce work in integration on Kubernetes.

@BAlmeidaS
Copy link
Author

Yes @SteNicholas I saw the issue, I decided opened mine anyway because I thought that one thing is integration with k8s and deploy an orchestrated pipeline with docker. Another thing is to deploy a Kubeflow pipelines targz (which is similar but not the same thing).

@savingoyal
Copy link
Collaborator

Thanks for opening the issue, @BAlmeidaS . Issues like these are really informative as we go about planning our roadmap.

@savingoyal savingoyal added the enhancement New feature or request label Dec 7, 2019
@Jeffwan
Copy link

Jeffwan commented Dec 28, 2019

@BAlmeidaS @
There's different options to integrate with KFP. User could use KFP SDK in metaflow or do something further and change orchestration and computing layer to kubeflow. Do you have some ideas in mind?

@valayDave
Copy link
Collaborator

Kubeflow's Pipeline features are a little different from Metaflow's DAG features. Kubeflow supports conditional Steps in workflows. Metaflow doesn't have support for conditional flows.

@talebzeghmi
Copy link

Kubeflow supports conditional branching concept that Metaflow doesn't. Metaflow could compile to Kubeflow via an intermediate representation (kubeflow/pipelines#3703)

@savingoyal
Copy link
Collaborator

savingoyal commented May 19, 2020

@talebzeghmi I responded in this other thread. Our current integration to AWS Step Functions' State Machine Representation is in PR #204 .

@savingoyal
Copy link
Collaborator

The reference implementation for AWS Step Functions is available here now. This should serve as a good starting point for any other scheduler integration.

@BAlmeidaS
Copy link
Author

BAlmeidaS commented Nov 17, 2020

Sorry for the enormous delay to answer this, I lost the tracking about this project. I was very excited about it when it launched but we developed our own solution to integrate with kfp. Answering @Jeffwan, IMO we could use kfp to deploy via metaflow. User may not notice that she is deploying a pipeline in kubeflow, even metaflow not having some features that kubeflow pipelines has. What you guys think about it??

sappier pushed a commit to sappier/metaflow that referenced this issue Apr 16, 2021
Refactor foreach implementation

* change recursive dfs sort to none-recursive dfs
* split Step.task() into separate ..._task() functions
@savingoyal
Copy link
Collaborator

Closing this issue given that #992 that addresses #50 has been merged. Kubeflow Pipelines also uses Argo Workflows under the hood so a layer of indirection through Kubeflow Pipelines doesn't really serve much benefit currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants