Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more logging to init() method of KeyGenerator (beginning, end) #112

Closed
amcp opened this issue Apr 7, 2018 · 2 comments
Closed

Add more logging to init() method of KeyGenerator (beginning, end) #112

amcp opened this issue Apr 7, 2018 · 2 comments

Comments

@amcp
Copy link
Contributor

amcp commented Apr 7, 2018

No description provided.

@amcp amcp mentioned this issue Apr 7, 2018
Merged
@vinaykumarchella
Copy link
Contributor

Currently, KeyGenerator init implementors provide enough logging during the initialization phase which could take longer depending on the input parameters. What extra logging are you looking for?

Sample logging:

Still initializing sample data for Keys. So far: 5/100

@amcp
Copy link
Contributor Author

amcp commented Apr 10, 2018

Correct, this was an artifact of my debugging. Closing.

@amcp amcp closed this as completed Apr 10, 2018
amcp pushed a commit to amcp/ndbench that referenced this issue Apr 10, 2018
Refactor KeyGenerators for more code reuse
eb6431a 
Fixes Netflix#111 and Netflix#112
vinaykumarchella pushed a commit that referenced this issue Apr 10, 2018
@vinaykumarchella
Refactor KeyGenerators for more code reuse (#126)
ed94d29 
Fixes #111 and #112
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amcp @vinaykumarchella