Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending vizceral #51

Closed
deejay1 opened this issue Feb 7, 2017 · 2 comments
Closed

Extending vizceral #51

deejay1 opened this issue Feb 7, 2017 · 2 comments

Comments

@deejay1
Copy link
Contributor

deejay1 commented Feb 7, 2017

Frankly I may have no idea what I'm doing, but it seems to me like vizceral installed from npm isn't exporting it's subclasses, therefore it's hard to write custom functionality like custom renderers without resorting to copying the entire vizceral codebase to my own project.

After several hours on the web I finally gave up and I'm writing this "issue", because maybe I'm doing something wrong, but trying to import something like the Connection class by doing import Connection from 'Vizceral/base/connection'; (or variants of it) it always ends up with something like Module not found: Error: Cannot resolve module 'Vizceral/base/connection'

Exporting the specific classes from vizceral.js works but needs to change the upstream files in my own repo.
Is this intended behaviour or am I doing something wrong here?

@jrsquared
Copy link
Contributor

None of the internal classes were exported. I just exported all the base classes (the ones in src/base). This should hopefully satisfy your use case. There is definitely more work that needs to be done to check to make sure the constructors are called with appropriate parameters and some documentation, but this should unblock you. Let me know if it works for you!

@deejay1
Copy link
Contributor Author

deejay1 commented Feb 9, 2017

Thanks for that, with Paweł's changes (who's sitting right next to me ;) we're more on track...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants