Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: permission request requires i18n support in macOS #1172

Closed
BlackHole1 opened this issue Dec 4, 2021 · 8 comments · Fixed by #1260
Closed

[feat]: permission request requires i18n support in macOS #1172

BlackHole1 opened this issue Dec 4, 2021 · 8 comments · Fixed by #1260
Assignees
Labels
enhancement New feature or request

Comments

@BlackHole1
Copy link
Collaborator

see:

NSMicrophoneUsageDescription: To ensure normal use, flat-native needs access to your microphone.
NSCameraUsageDescription: To ensure normal use, flat-native needs access to your camera.

we need support Chinese desc

@BlackHole1 BlackHole1 added enhancement New feature or request good first issue Good for newcomers labels Dec 4, 2021
@BlackHole1
Copy link
Collaborator Author

@Leooeloel Please provide a description in Chinese

@Leooeloel
Copy link
Collaborator

Please follow the following prompts in English and Chinese.

In order to work properly, Flat needs permission to access microphone

In order to work properly, Flat needs permission to access camera

为了能够正常使用,Flat 需要访问麦克风的权限

为了能够正常使用,Flat 需要访问摄像头的权限

@LitoMore
Copy link
Member

LitoMore commented Dec 7, 2021

The sentence below makes me feel that the user must provide permissions, otherwise the software will not be usable at all. And I don't know what it needs permissions for, and when it will be used.

In order to work properly, Flat needs permission to access...

FYI: https://techcrunch.com/2014/04/04/the-right-way-to-ask-users-for-ios-permissions/

@Leooeloel
Copy link
Collaborator

Yes, I do confuse users with this approach, and I will reorganize the requirements to ensure a classroom experience without violating user privacy.

Thanks for the reminder, I'll ask you to review it when it's ready.

@Matrixbirds
Copy link
Contributor

Any work in progress needs to update?
cc: @Leooeloel

@Leooeloel
Copy link
Collaborator

We don't ask users for permissions when they first open flat.

Currently flat does not actively ask for permissions from users, the prompt to ask for permissions in flat is triggered by the user. For example, when a user clicks to open the camera, but does not give flat permission to use the camera, this prompt will appear. This way the user doesn't feel too confused.

Here we need your help to update the authorization prompt.

Please follow the following prompts in English and Chinese.

In order to work properly, Flat needs permission to access microphone

In order to work properly, Flat needs permission to access camera

为了能够正常使用,Flat 需要访问麦克风的权限

为了能够正常使用,Flat 需要访问摄像头的权限

@Leooeloel
Copy link
Collaborator

cc: @Matrixbirds @LitoMore @BlackHole1

@BlackHole1
Copy link
Collaborator Author

Okey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants