Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flat-components): users panel #1801

Merged
merged 3 commits into from
Dec 28, 2022

Conversation

hyrious
Copy link
Member

@hyrious hyrious commented Dec 16, 2022

Internal synced store / message change:

  1. Added one storage whiteboard holding a map (Map<string, boolean>) of users with whiteboard access. Logic behind:

    fastboard.room.isWritable =
      isCreator ||
      onStageUsers[this.userUUID] ||
      whiteboard[this.userUUID]
    
    fastboard.room.disableDeviceInputs = !whiteboard[this.userUUID]
  2. Added 3 peer commands about requesting/notifying device state, flow:

    // 1. teacher request some user to turn on camera
    teacher."request-device"({ roomUUID, camera: true }, userUUID)
    // 2. user turn on/off camera, send back one response
    user."request-device-response"({ roomUUID, camera: false }, ownerUUID)
    
    // `camera` above can also be `mic`

    When teacher turn off the device of some user, he will send one more peer command to this user:

    teacher."notify-device-off"({ roomUUID, camera: false }, userUUID)

@aderan @vince-hz

@hyrious hyrious changed the title refactor users list feat(flat-components): users panel Dec 16, 2022
@hyrious hyrious marked this pull request as draft December 16, 2022 04:16
crimx
crimx previously approved these changes Dec 26, 2022
refactor(flat-stores): save allow drawing state

feat(flat-components): users panel

fix font size

feat(flat-pages): users panel

remove unused variables

i18n

feat: whiteboard access, ask user to turn on devices
@hyrious hyrious marked this pull request as ready for review December 28, 2022 08:58
@hyrious hyrious requested a review from crimx December 28, 2022 08:58
@hyrious hyrious merged commit e46e275 into netless-io:main Dec 28, 2022
@hyrious hyrious deleted the refactor-users-list branch December 28, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants