Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Removes Unused files #766

Merged
merged 4 commits into from
Jun 26, 2021

Conversation

rbrishabh
Copy link
Contributor

@rbrishabh rbrishabh commented Jun 26, 2021

Fixes #713

Hey @BlackHole1, how does this look?
Let me know if this needs any changes! Thanks

Copy link
Collaborator

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one small problem.

desktop/renderer-app/package.json Show resolved Hide resolved
desktop/renderer-app/package.json Outdated Show resolved Hide resolved
desktop/renderer-app/src/react-app-env.d.ts Outdated Show resolved Hide resolved
@rbrishabh
Copy link
Contributor Author

Hey @BlackHole1, how does this look now?
let me know if this needs any changes and I'm happy to do those

@BlackHole1
Copy link
Collaborator

LGTM

@BlackHole1 BlackHole1 merged commit 37dffbf into netless-io:main Jun 26, 2021
@BlackHole1
Copy link
Collaborator

thx for your contribution, we will contact you recently to send our gift

@rbrishabh
Copy link
Contributor Author

Thanks for your quick reviews! happy to help!
oh! excited for the gift :)

if there's anywhere I can help, just tag me! Thanks again

@Leooeloel Leooeloel mentioned this pull request Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor]: remove useless code / file / dependencies
3 participants