Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor]: remove useless code / file / dependencies #713

Closed
BlackHole1 opened this issue Jun 6, 2021 · 1 comment · Fixed by #766
Closed

[refactor]: remove useless code / file / dependencies #713

BlackHole1 opened this issue Jun 6, 2021 · 1 comment · Fixed by #766
Labels
good first issue Good for newcomers

Comments

@BlackHole1
Copy link
Collaborator

BlackHole1 commented Jun 6, 2021 •
edited
Loading

for historical reasons there are code that we will never use again and we should delete them instead of keeping them in the project.

e.g:

  1. /desktop/renderer-app/src/taskUuids.ts
  2. /desktop/renderer-app/src/custom.d.ts
  3. /desktop/renderer-app/src/react-app-env.d.ts
  4. /desktop/renderer-app/package.json -> scripts -> react-app-rewired and eject
  5. /desktop/renderer-app/package.json -> devDependencies -> edit-json-file
  6. ...
@BlackHole1 BlackHole1 added the good first issue Good for newcomers label Jun 6, 2021
@rbrishabh
Copy link
Contributor

rbrishabh commented Jun 26, 2021 •
edited
Loading

Hey! I can help with this

@BlackHole1 BlackHole1 mentioned this issue Jun 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup: Removes Unused files rbrishabh/flat
2 participants
@BlackHole1 @rbrishabh