-
Notifications
You must be signed in to change notification settings - Fork 196
Conversation
Nice, I hadn't heard of Homebrew for Linux before. 💥 |
yup, i remembered that a german webhosting company offered it along with full-fledged ssh access on a shared host and how this is exactly what we need (hope you can google-translate it): https://blog.uberspace.de/brauen-oder-toasten/ |
this is now based on an older commit, because the swift commit fails all builds |
This is an example build which uses this feature successfully: https://app.netlify.com/sites/edge-functions-ts/deploys/5eb20aaf6ddfc20006027e9d |
What if we removed this from the included_software doc so that we made it clear it's not generally available, then we could continue testing without officially "supporting" it? Then we could decide on a release date if this is a pattern we like. |
I think that it's a good idea, or even mark it as experimental. This change as it is makes much more sense than other tools that we've merged before, and I don't think we should hold it back. |
this is currently blocked on #401 |
Mainly for allowing native node modules to use homebrew stuff
@netlify/backend are you happy to merge this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's get it out
@@ -449,6 +450,13 @@ install_dependencies() { | |||
fi | |||
fi | |||
|
|||
# Homebrew from Brewfile | |||
if [ -f Brewfile ] || [ ! -z "$HOMEBREW_BUNDLE_FILE" ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw, -n
should also be equivalent to ! -z
# | ||
################################################################################ | ||
USER buildbot | ||
RUN /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any concern that we aren't pulling from a static/stable tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a good point. let's do that as part of a general release
Adding support for Homebrew aka Linuxbrew: https://docs.brew.sh/Homebrew-on-Linux
This shall be amazing because:
Brewfile
in their git to specify dependenciesI also hope this will allow us to remove some lesser-used tooling from the image and offer users to install it via Homebrew instead.
Good candidates for that:
Test plan
Has been verified locally with
Brewfile
and custom Brewfile name via$HOMEBREW_BUNDLE_FILE
Cute animal