Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add Lua support #404

Closed
wants to merge 1 commit into from
Closed

Add Lua support #404

wants to merge 1 commit into from

Conversation

Benaiah
Copy link
Contributor

@Benaiah Benaiah commented Apr 28, 2020

Installs lua5.1 (which is also available as lua), lua5.3, and luajit.

Does not install LuaRocks, Lua's community package manager. This is because it isn't clear how to install LuaRocks in a way that would work for more than one installed version of Lua. The current version of LuaRocks expects Lua 5.3, but the lua CLI that's installed by apt is Lua 5.1.

Also evaluated https://dhavalkapil.com/luaver/, but that doesn't appear to be currently maintained and is significantly more complicated than this PR.

@Benaiah Benaiah requested a review from a team as a code owner April 28, 2020 21:00
@mraerino
Copy link
Contributor

mraerino commented May 3, 2020

With #411 you could just use the homebrew formula: https://formulae.brew.sh/formula-linux/lua
luarocks is also available there.
We might also refrain from installing this in the image and just tell people to use a Brewfile?

@vbrown608
Copy link
Contributor

We're going to pause adding new dependencies to the build image while we review our handling of preinstalled dependencies.

@vbrown608 vbrown608 removed their assignment Jul 10, 2020
@ingride
Copy link
Contributor

ingride commented Aug 21, 2020

should this PR be closed if we don't plan to ship it?

@kitop kitop closed this May 11, 2022
@kitop kitop deleted the lua branch May 11, 2022 14:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants