fix: fallback should there be an error getting the functions error page template #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Benchmark resultsComparing with a2bbaf0 Package size: 380 MB⬇️ 0.00% decrease vs. a2bbaf0 Legend
|
erezrokah
previously approved these changes
Apr 1, 2022
erezrokah
approved these changes
Apr 1, 2022
eduardoboucas
added a commit
that referenced
this pull request
Apr 18, 2022
* fix(deps): update dependency @netlify/plugins-list to ^6.17.0 (#4472) * fix(deps): update dependency @netlify/plugins-list to ^6.17.0 * chore: update contributors field Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> * fix(deps): update dependency commander to v9.1.0 (#4466) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com> * chore(main): release 9.13.4 (#4470) Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> * fix(deps): update dependency netlify to ^11.0.1 (#4473) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): update dependency @netlify/build to ^26.5.1 (#4475) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): update dependency @netlify/config to ^17.0.19 (#4476) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): bump minimist from 1.2.5 to 1.2.6 in /tests/integration/eleventy-site (#4477) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump minimist from 1.2.5 to 1.2.6 in /site (#4478) Bumps [minimist](https://github.com/substack/minimist) from 1.2.5 to 1.2.6. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.5...1.2.6) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ehmicky <ehmicky@users.noreply.github.com> * fix(deps): update dependency stripe to v8.211.0 (#4467) * fix(deps): update dependency stripe to v8.211.0 * style: don't format lock files Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: erezrokah <erezrokah@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(main): release 9.13.5 (#4474) Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> * fix(deps): update dependency minimist to v1.2.6 (#4480) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): update dependency typescript to v4.6.3 (#4481) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(deps): update rust crate log to 0.4.16 (#4482) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(deps): update dependency stripe to v8.212.0 (#4483) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(deps): update dependency gh-release-fetch to v3.0.2 (#4479) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(main): release 9.13.6 (#4485) Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> * chore(deps): update dependency @netlify/eslint-config-node to ^5.1.8 (#4487) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix: polling for API Authentication (#4490) * feat: add local dev support for Go scheduled functions (#4491) * fix: detection for Go scheduled functions * fix: incompatible fs import * chore: fix conventional message error * fix: parse schedule from config * fix: unsupported optional chaining * fix: broken function test without config * chore: fix prettier warnings * fix: additional checks in NetlifyFunction * feat: assert valid next_run in test * chore: update names and tests * feat(dev-graph): populate X-Nf-Graph-Token header (#4493) * feat(dev-graph): populate X-Nf-Graph-Token header * chore: update contributors field * chore: update contributors field Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(main): release 9.14.0 (#4492) * chore(main): release 9.14.0 * chore: update contributors field * chore: update contributors field * chore: update contributors field Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com> * feat: added scheduled functions template for Go (#4495) * feat: go scheduled functions template * chore: update contributors field * chore: placeholder for github handle in go mod * chore: remove unnecessary makefile * chore: go version update Co-authored-by: karagulamos <karagulamos@users.noreply.github.com> * chore(main): release 9.15.0 (#4496) Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> * fix(deps): update dependency @netlify/plugins-list to ^6.18.1 (#4494) * fix(deps): update dependency @netlify/plugins-list to ^6.18.1 * chore: update contributors field Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat: improve functions error messages (#4486) * feat: implement better error pages for functions in CLI * chore(main): release 9.16.0 (#4497) Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> * fix: fallback should there be an error getting the functions error page template (#4499) * fix: wrap render template in try catch * chore: include template in files tracked by npm * chore(main): release 9.16.1 (#4500) Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> * fix(deps): update dependency cron-parser to v4.3.0 (#4504) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): update dependency stripe to v8.215.0 (#4505) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(main): release 9.16.2 (#4510) Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> * fix(deps): update dependency @netlify/build to ^26.5.2 (#4512) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): update dependency @netlify/config to ^17.0.20 (#4513) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(main): release 9.16.3 (#4514) Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> * fix(deps): update dependency @netlify/plugins-list to ^6.19.0 (#4516) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): update dependency lambda-local to v2.0.2 (#4443) * fix(deps): update dependency lambda-local to v2.0.2 * chore: update contributors field * feat: update to correctly mirror synchronous execution (closes #4304) * chore: update contributors field * chore: update contributors field * fix: format * chore: update contributors field * chore: update contributors field * fix: tests * chore: update contributors field * chore: update contributors field * fix: another test * chore: update contributors field * fix: another test Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com> Co-authored-by: Skn0tt <Skn0tt@users.noreply.github.com> Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com> Co-authored-by: Simon Knott <info@simonknott.de> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com> * chore(main): release 9.16.4 (#4517) * chore(main): release 9.16.4 * chore: update contributors field Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com> * fix(deps): update dependency stripe to v8.216.0 (#4520) Co-authored-by: Renovate Bot <bot@renovateapp.com> * fix(deps): update dependency semver to v7.3.6 (#4518) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency ava to v4.2.0 (#4519) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(deps): update dependency winston to v3.7.2 (#4521) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com> * chore(main): release 9.16.5 (#4525) Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> * chore(deps): update codecov/codecov-action action to v3 (#4522) Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * fix(deps): update dependency @netlify/build to ^26.5.3 (#4529) Co-authored-by: Renovate Bot <bot@renovateapp.com> * chore(deps): update dependency @netlify/eslint-config-node to v6 (#4501) * chore(deps): update dependency @netlify/eslint-config-node to v6 * chore: fix eslintrc * chore: fix linting * chore: update shrinkwrap file Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: ehmicky <ehmicky@gmail.com> Co-authored-by: erezrokah <erezrokah@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore(main): release 9.16.6 (#4530) Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * chore: merge main * chore: remove dependency * chore: fix linting errors * chore: fix test * chore: remove duplicate test Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Erez Rokah <erezrokah@users.noreply.github.com> Co-authored-by: token-generator-app[bot] <82042599+token-generator-app[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ehmicky <ehmicky@users.noreply.github.com> Co-authored-by: Antonio Nuno Monteiro <anmonteiro@gmail.com> Co-authored-by: Karagulamos <karagulamos@gmail.com> Co-authored-by: Daniel Woelfel <dwwoelfel@gmail.com> Co-authored-by: token-generator-app[bot] <token-generator-app[bot]@users.noreply.github.com> Co-authored-by: karagulamos <karagulamos@users.noreply.github.com> Co-authored-by: Jackie Macharia <jackline.macharia@netlify.com> Co-authored-by: Netlify Team Account 1 <netlify-team-account-1@users.noreply.github.com> Co-authored-by: Skn0tt <Skn0tt@users.noreply.github.com> Co-authored-by: Simon Knott <info@simonknott.de> Co-authored-by: kodiakhq[bot] <kodiakhq[bot]@users.noreply.github.com> Co-authored-by: ehmicky <ehmicky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wraps functions render error template block in try catch and returns the previous view should there be a problem getting the error template.
Part of https://github.com/netlify/pod-serverless/issues/78
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
