Fix: Return .html file when file and folder share name #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you have a folder and a file with the same name (e.g., foo.html and foo/), Netlify will serve the contents of foo.html. Until now, netlify dev was inconsistent with that behavior and returned a 403 Forbidden error (because directory listings are forbidden) in this scenario. This commit makes netlify dev behave consistent with Netlify by serving the .html (or .htm) file instead of returning 403 Forbidden. Fixes: netlify#1017
|
Deploy request for cli accepted. Accepted with commit d0eb2d1 https://app.netlify.com/sites/cli/deploys/5f47b9f2074b4f0007c6186e |
erezrokah
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
This is great @FinnWoelm!
Thank you for adding the test case for it too ❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Netlify ❤️,
I'm submitting this PR as suggested by @erezrokah in order to fix issue #1017.
- Summary
When you have a folder and a file with the same name (e.g., foo.html and foo/), Netlify will serve the contents of foo.html.
Until now, netlify dev was inconsistent with that behavior and returned a 403 Forbidden error in this scenario (because directory listings are forbidden).
This PR makes netlify dev behave consistent with Netlify by serving the .html (or .htm) file instead of returning 403 Forbidden.
Fixes: #1017
- Test plan
I first added a test to
tests/command.dev.test.js. I ran the test and confirmed that it failed. Then I implemented the fix. I reran the test and the test passed.I ran
npm run testand everything came back green.- Description for the changelog
Fix: Return .html file when file and folder share name (#1017)
- A picture of a cute animal (not mandatory but encouraged)
Happy to make any changes/improvements you deem necessary! Thanks for all your great work 🙌