fix(command-deploy): pass custom deploy dir to netlify client #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy request for cli accepted. Accepted with commit fbcc04a https://app.netlify.com/sites/cli/deploys/5f5ea4b4e4782b000735ebc7 |
monsonjeremy
changed the title
|
Thanks @monsonjeremy, closing this in favour of #1272. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
This PR aims to fix the issue described in 1227.
The idea here is pretty simple, we pass the name of the custom deploy directory to the netlify js client via the
deployDiroption.The rest is handled in this PR in the
netlify/js-clientrepo.- Test plan
See the JS Client PR for testing information. The change here can exist entirely on it's own, but depends on that PR to actually change anything.
- Description for the changelog
fix(command-deploy): support hidden directories for deploy
-dflag