fix(command-deploy): align file filtering with buildbot #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2020
ehmicky
reviewed
Sep 23, 2020
| let actualContent | ||
| try { | ||
| const response = await fetch(`${siteUrl}${path}`) | ||
| if (response.ok) { |
There was a problem hiding this comment.
Should the test always fail when response.ok is not true? If so, I am wondering if there should be a t.true(response.ok)?
Also wondering about whether the test should always fail when fetch() or response.text() throws. In which case, t.notThrowsAsync() could be used.
There was a problem hiding this comment.
Oops, nevermind, I see that content is sometimes undefined in some of the tests. 馃憤
ehmicky
approved these changes
Sep 23, 2020
| let actualContent | ||
| try { | ||
| const response = await fetch(`${siteUrl}${path}`) | ||
| if (response.ok) { |
There was a problem hiding this comment.
Oops, nevermind, I see that content is sometimes undefined in some of the tests. 馃憤
erezrokah
force-pushed
the
fix/deploy_missing_files
branch
from
2ae6666
to
5f6d0f8
Compare
|
Tests are failing since the team we're using to deploy edge handlers on CI doesn't have access to do so anymore. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Related to netlify/js-client#157 and #1227.
Fixes #1225 (comment)
The CLI deploy command relies on
js-clientdefault filter to skip some files when deploying.This is done here:
https://github.com/netlify/js-client/blob/55650048fc7fe6288816c1dc172b27024cbd1586/src/deploy/util.js#L8
and trying to emulate the code here:
https://github.com/netlify/open-api/blob/e72e2eb2d7eedf02bccc5916fc0330022f7f823b/go/porcelain/deploy.go#L692
This PR fixes a few discrepancies with our buildbot:
.public) - fixes part of Manual deployment hangs with a deployment folder that starts with a dot聽#1227.node_moduleswhen inside a publish folder. Fixes Community report: CLI behaviour does not match containerized behaviour regarding .gitignore files聽#1225 (comment) and matches buildbot behaviour. Only difference is thatnode_modulesare ignored if a user tries to publish the current project dir.\/__MACOSXpart wasn't working as I'm not sure howbasenamecan result in a string containing a/.- Test plan
Added tests
- Description for the changelog
Align deploy file filtering with buildbot
- A picture of a cute animal (not mandatory but encouraged)
馃惔