Add array-callback-return ESLint rule
#1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
commented
Oct 15, 2020
| jid: | ||
| gjid: | ||
| jid: | ||
| gjid: |
There was a problem hiding this comment.
Unrelated change. Not sure why Prettier/ESLint did not pick this.
ehmicky
commented
Oct 15, 2020
| @@ -35,7 +35,7 @@ const startServer = async ({ cwd, env = {}, args = [] }) => { | |||
| close: async () => { | |||
| selfKilled = true | |||
| const pids = await pidtree(ps.pid).catch(() => []) | |||
| pids.forEach((pid) => () => { | |||
| pids.forEach((pid) => { | |||
There was a problem hiding this comment.
I believe this was a bug. What do you think @erezrokah ?
There was a problem hiding this comment.
Yes I think so. A bad shameful copy paste probably
erezrokah
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
array-callback-returnESLint rule.This is a useful linting rule, and actually I think applying it in this PR might have found some bugs.