Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixes an issue on windows #3865

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tools/affected-test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env node
// @ts-check
const { existsSync, statSync } = require('fs')
const { join } = require('path')
const process = require('process')

const { grey } = require('chalk')
Expand All @@ -13,7 +14,9 @@ const { DependencyGraph, fileVisitor, visitorPlugins } = require('./project-grap

const getChangedFiles = async (compareTarget = 'origin/main') => {
const { stdout } = await execa('git', ['diff', '--name-only', 'HEAD', compareTarget])
return stdout.split('\n')
// git is using posix paths so adjust them to the operating system by
// using nodes join function
return stdout.split('\n').map((filePath) => join(filePath))
}

/**
Expand All @@ -23,7 +26,9 @@ const getChangedFiles = async (compareTarget = 'origin/main') => {
* @returns {string[]}
*/
const getAffectedFiles = (changedFiles) => {
const testFiles = sync(ava.files)
// glob is using only posix file paths on windows we need the `\`
// by using join the paths are adjusted to the operating system
const testFiles = sync(ava.files).map((filePath) => join(filePath))

// in this case all files are affected
if (changedFiles.includes('npm-shrinkwrap.json') || changedFiles.includes('package.json')) {
Expand Down