fix: stop pass through request params for function redirects

[tinfoil-knight]

🎉 Thanks for submitting a pull request! 🎉

Summary

Fixes #4273

Query parameters specified in function redirects are not being passed (they're over-written by the request parameters) by netlify dev. This is different from currently observed production behaviour.

This is due to an intentional change in #1605 to match the production behaviour at that time.

---

Difference b/w current local & production behaviour can be verified with the minimal reproduction & production deploy link below:

Minimal reproduction of the issue: https://github.com/KK-Learning-Gym/4273-with-fn (see netlify.toml)

Production Deploy: https://with-fn-testing.netlify.app

Quick Links:

Redirect with config from the updated test in this PR:

https://with-fn-testing.netlify.app/api/test?foo=1&foo=2&bar=1&bar=2

Redirects to
/.netlify/functions/echo?a=1&a=2 on production
/.netlify/functions/echo?foo=1&foo=2&bar=1&bar=2 locally

Redirect with config mentioned in #4273 on production:

https://with-fn-testing.netlify.app/.netlify/functions/bar/?url=bar

Redirects to
.netlify/functions/bar/?url=bar on production
.netlify/functions/bar/?url= locally

Also see #4273 (comment)

---

This PR attempts to resolve the differences described above b/w netlify dev & production.

---

For us to review and ship your PR efficiently, please perform the following steps:

• Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
• Read the contribution guidelines 📖. This ensures your code follows our style guide and
  passes our tests.
• Update or add tests (if any source code was changed or added) 🧪
• Update or add documentation (if features were changed or added) 📝
• Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)
🦁

[github-actions]

📊 Benchmark results

Comparing with ec1a05e

Package size: 222 MB

(no change)

^  228 MB                                                                                                 
│   ┌──┐   222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB  222 MB 
│   |  |    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    

Legend

• T-30 (4a6cb0e): 228 MB
• T-29 (f02d08e): 228 MB
• T-28 (64e48dc): 228 MB
• T-27 (7c209cb): 228 MB
• T-26 (f362ec7): 228 MB
• T-25 (585d91e): 228 MB
• T-24 (91f4ab2): 228 MB
• T-23 (868ec26): 228 MB
• T-22 (df0c767): 228 MB
• T-21 (0290c45): 228 MB
• T-20 (7337755): 228 MB
• T-19 (fb72d92): 228 MB
• T-18 (7317269): 228 MB
• T-17 (3dfa6e5): 228 MB
• T-16 (11b9887): 228 MB
• T-15 (3994939): 228 MB
• T-14 (53facba): 228 MB
• T-13 (d506922): 228 MB
• T-12 (dc0615e): 228 MB
• T-11 (27b4843): 222 MB
• T-10 (1e83238): 222 MB
• T-9 (ea87d45): 222 MB
• T-8 (d00841d): 222 MB
• T-7 (060c205): 222 MB
• T-6 (d2d7665): 222 MB
• T-5 (55df500): 222 MB
• T-4 (e1b911f): 222 MB
• T-3 (58732a2): 222 MB
• T-2 (ddeec5e): 222 MB
• T-1 (ec1a05e): 222 MB
• T (current commit): 222 MB

[tinfoil-knight]

Note: I confirmed w/ https://github.com/eric-silverman on Slack for approval before creating the PR for the attached issue.

[danez]

LGTM 🎉

Can we add an additional assertion that tests the :splat behavior with functions?

[tinfoil-knight]

Can we add an additional assertion that tests the :splat behavior with functions?

Yeah. I'll add a test-case.

[danez]

Feel free to merge. You can also use kodiak for merging, by simply adding the automerge label.

[tinfoil-knight]

@danez I don't have access to merge or add any labels yet.

[danez]

Oh I see, I can merge if you want?

[tinfoil-knight]

Oh I see, I can merge if you want?

Yeah. Please do.