New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added missing mock geo data #5231
Merged
nickytonline
merged 9 commits into
main
from
nickytonline/add-long-lat-to-geo-mock-data
Nov 16, 2022
Merged
fix: added missing mock geo data #5231
nickytonline
merged 9 commits into
main
from
nickytonline/add-long-lat-to-geo-mock-data
Nov 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
π Benchmark resultsComparing with 3f3eb14 Package size: 247 MBβ¬οΈ 0.00% decrease vs. 3f3eb14
Legend
|
orinokai
previously approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
ascorbic
reviewed
Nov 16, 2022
sarahetter
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Thanks for submitting a pull request! π
Summary
Adds missing mock geo data for local development. This can be merged before https://github.com/netlify/pod-ecosystem-frameworks/issues/305 is completed.
Fixes #5232
Relates to https://github.com/netlify/pod-ecosystem-frameworks/issues/305
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)