chore: updates for converting the api command #6295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khendrikse
changed the title
khendrikse
force-pushed
the
CP-476/convert-api-command
branch
from
0c074d0
to
8596b3f
Compare
|
Something that I'd like some advice about is this: I've now implemented this change: Before:
After:
Because I really dislike when that outro part only has a little hook...
But sometimes we might not have a message to show there... |
|
@khendrikse I understand. When there isn't a message will it end with the last line of the table above it? I think that is fine. |
Yeah that's the problem @samkap, right now we don't have easy logic that will allow that. We could default to 'Done' or 'Finished' if someone does not pass a message? |
khendrikse
force-pushed
the
CP-476/convert-api-command
branch
from
8596b3f
to
96688c6
Compare
ericapisani
approved these changes
Jan 11, 2024
khendrikse
merged commit 493a6a1
into
CP-101/design-system-clack-implementation
30 checks passed
khendrikse
added a commit
that referenced
this pull request
Jan 12, 2024
* chore: improve API command with spinner and better formatting * chore: add support for json only
khendrikse
added a commit
that referenced
this pull request
Jan 12, 2024
* chore: improve API command with spinner and better formatting * chore: add support for json only
khendrikse
added a commit
that referenced
this pull request
Jan 15, 2024
* chore: improve API command with spinner and better formatting * chore: convert api command to use clack * chore: convert link to use NetlifyLog and clack * chore: updates for converting the api command (#6295) * chore: improve API command with spinner and better formatting * chore: add support for json only * chore: more converting of link and changed json only support * revert weird chalk helper * chore: implement some feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This adds some changes to converting the api command into using the new NetlifyLog. It is part of a bigger piece of work that can be seen in #6293. This is also the reason why this PR is merged into the branch CP-101/design-system-clack-implementation. It's a way in which I'm trying to keep possible failing tests, but also the review work to a minimum amount of work for those who are reviewing.
Before
After
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)