chore: convert link command #6313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khendrikse
force-pushed
the
CP-477-convert-link-command
branch
from
4e5c0ab
to
aa3f2c8
Compare
* chore: improve API command with spinner and better formatting * chore: add support for json only
khendrikse
force-pushed
the
CP-477-convert-link-command
branch
from
aa3f2c8
to
9709b52
Compare
khendrikse
commented
Jan 12, 2024
| @@ -22,9 +22,9 @@ export const unlink = async (options: OptionValues, command: BaseCommand) => { | |||
| }) | |||
|
|
|||
| if (site) { | |||
| NetlifyLog.success(`Unlinked ${site.configPath} from ${siteData ? siteData.name : siteId}`) | |||
| NetlifyLog.success(`Unlinked from ${siteData ? siteData.name : siteId}`) | |||
There was a problem hiding this comment.
This did not work before my changes :D it was always undefined
khendrikse
commented
Jan 12, 2024
| */ | ||
| // @ts-expect-error TS(7006) FIXME: Parameter 'command' implicitly has an 'any' type. | ||
| const linkPrompt = async (command, options) => { | ||
| const linkPrompt = async (command: BaseCommand, options: OptionValues) => { |
There was a problem hiding this comment.
This is the big file to look at
ericapisani
reviewed
Jan 12, 2024
|
@ericapisani @eduardoboucas thanks!! I implemented your feedback :) |
khendrikse
merged commit 5d98d73
into
CP-101/design-system-clack-implementation
30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes: https://linear.app/netlify/issue/CT-477/convert-link-command-to-clack
This converts the
linkcommand into using the new NetlifyLog. It is part of a bigger piece of work that can be seen in #6293. This is also the reason why this PR is merged into the branch CP-101/design-system-clack-implementation. It's a way in which I'm trying to keep possible failing tests, but also the review work to a minimum amount of work for those who are reviewing.It also changes a few things for
outro()Before
I'm sorry it's a looot of screenshotting otherwise
After
CleanShot.2024-01-12.at.17.15.45.mp4
For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)