fix: import function template metadata as module #6516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Thanks for submitting a pull request! π
Summary
Fixes #6250
https://linear.app/netlify/issue/CT-1059/creating-new-functions-in-the-cli-via-ntl-functionscreate-is-broken
When we moved to using ESM, we left these function template metadata files (
.netlify-function-template.js
) alone. Some of the templates don't havepackage.json
files, and those continued to be imported fine (including the two used in existing integration tests) because the closestpackage.json
(in the root directory) hadtype: module
. Templates with their ownpackage.json
files failed because those didn't havetype: module
. Since those template-specificpackage.json
s are related more to the actual{{name}}
template file and not the metadata file, I decided to leave them alone and instead rename the metadata files to use.mjs
across the board.For us to review and ship your PR efficiently, please perform the following steps:
passes our tests.
A picture of a cute animal (not mandatory, but encouraged)
![Screenshot 2024-04-17 at 4 20 40 PM](https://private-user-images.githubusercontent.com/1895116/323367798-0d40b526-7f68-41cb-9502-6f37713dd154.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA2MDg0NjksIm5iZiI6MTcyMDYwODE2OSwicGF0aCI6Ii8xODk1MTE2LzMyMzM2Nzc5OC0wZDQwYjUyNi03ZjY4LTQxY2ItOTUwMi02ZjM3NzEzZGQxNTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MTBUMTA0MjQ5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDk4MTgzYzJiNzgwNDcwMTM0MDFkODM5OTE1YjFiY2M1YTYyNDk4ZDA0ZTNhMjg1YTY5OGI2MmM1NzY0ZjhkYiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.P3hBCE_jQ03M4r12ihM8rf_QUoE6_sVKVesxKSwEn8g)