This repository has been archived by the owner on Sep 8, 2021. It is now read-only.
convert from netlify to go #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verythorough
suggested changes
Mar 9, 2017
README.md
Outdated
| @@ -1,16 +1,16 @@ | |||
| # Netlify Commerce JS | |||
| # Go Commerce JS | |||
README.md
Outdated
|
|
||
| This is a JS client library for [Netlify Commerce](https://github.com/netlify/netlify-commerce) API. | ||
| This is a JS client library for [Go Commerce](https://github.com/netlify/gocommerce) API. |
README.md
Outdated
| @@ -80,7 +80,7 @@ commerce.setCountry("USA"); | |||
| commerce.setCurrency("USD"); | |||
| ``` | |||
|
|
|||
| You can use Netlify Commerce JS together with [authlify](https://github.com/netlify/authlify) to let users log in and claim view order history. | |||
| You can use Go Commerce JS together with [GoTrue](https://github.com/netlify/gotrue) to let users log in and claim view order history. | |||
|
Looks good to me! Though I can't fully confirm the code part is good. I assume npm/etc. handles the name change so projects using netlify-commerce-js don't break? |
|
Authlify needs to be changed to goTrue in the readme |
|
also src/index.js references |
|
I am not seeing those @bdougie |
|
my bad, I was looking at master. This is good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mostly just a lot of search and replace ~ @biilmann could you check this is right?