Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External redirect path + base path #131

Closed
bcomnes opened this issue Dec 27, 2017 · 1 comment
Closed

External redirect path + base path #131

bcomnes opened this issue Dec 27, 2017 · 1 comment

Comments

@bcomnes
Copy link
Contributor

bcomnes commented Dec 27, 2017

Related to: #102

ie, in general for the CMS, it would make sense that the base path is "/admin" and that all URLs are generated based on that (both redirects after a social login and URLs in emails for confirmation, remember me, etc)
if we had that, I would check the return_to URL in the request for an external provider and verify it like this:

  1. Is the domain/protocol the same as the SiteURL on file?
  2. Is the path a child of the base path
@brycekahle
Copy link
Contributor

Duplicate of #102 and #112.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants