-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Error: Cannot find module 'follow-redirects' #1834
Comments
I believe this is introduced by #1719. Perhaps the |
Hi @elliottsj , Thanks for logging a ticket and the detailed summary. Are you able to provide a minimal repro project that exhibits the issue? I've unfortunately not been able to reproduce this with one of our demo sites and installing the node modules using |
If using pnpm, have you enabled hoisting? See this: https://github.com/netlify/next-runtime#using-with-pnpm |
As we haven't heard back in 3 weeks, I'm closing this issue. If you're still having problems, please don't hesitate to re-open. |
I'm currently getting this issue testing out a bug in Next 13 with an ISR page in the app dir. I'm using npm, but I also tried pnpm with hoisting as mentioned, but the issue persists. Not sure what the solution is yet, but I'm going to reopen this as it's blocking me test another issue.
I'm not really sure why it's not int the bundle. It's choking on this line of code.
|
I had forgot to save the
|
Thanks for looking into this, I can confirm that setting
in Although, in my opinion, requiring In particular, if my application happens to depend on a different version of the follow-redirects package than @netlify/plugin-nextjs, let's say a hypothetical v2.0.0, then the Netlify runtime will import that instead of the expected v1.15.2. To correctly support pnpm, public-hoist-pattern should not be required. |
Summary
This error page is rendered upon visiting our app:
Stack trace:
Netlify internal ID:
01GKMNY9325XC365GG3KHDAQNX
.Steps to reproduce
Use pnpm and deploy a site using the Netlify CLI. The command we are using is:
Using netlify-cli@12.0.10 and @netlify/plugin-nextjs@4.29.3.
A link to a reproduction repository
No response
Next Runtime version
4.29.3
More information about your build
netlify.toml
)What OS are you using?
Mac OS
Your netlify.toml file
`netlify.toml`
Your public/_redirects file
`_redirects`
# Paste content of your `_redirects` file here
Your
next.config.js
file`next.config.js`
Builds logs (or link to your logs)
Build logs
Function logs
Function logs
.next JSON files
generated .next JSON files
The text was updated successfully, but these errors were encountered: