Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gobin in makefile in favor of plain go #416

Closed
jasonbarry opened this issue Jan 19, 2023 · 1 comment · Fixed by #444
Closed

Remove gobin in makefile in favor of plain go #416

jasonbarry opened this issue Jan 19, 2023 · 1 comment · Fixed by #444

Comments

@jasonbarry
Copy link
Contributor

There's a step in the makefile that depends on gobin, which has been archived as of Nov 8 of last year. We should use the normal go binary instead of depend on gobin.

@akahn
Copy link
Contributor

akahn commented Jan 19, 2023

Simply replacing gobin run with go run results in this error when generating Go source:

	The go.mod file for the module providing named packages contains one or
	more replace directives. It must not contain directives that would cause
	it to be interpreted differently than if it were the main module.

According to golang/go#44840 there is no direct workaround for this issue, so we'll have to find a different solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants