Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Commit

Permalink
chore(ci): fix our npm caching strategy for our e2e nextjs tests (#655)
Browse files Browse the repository at this point in the history
* chore(ci): fix our npm caching strategy for our e2e nextjs tests

* chore(ci): allow e2e action to be tested under some PRs

* chore(ci): typo in workflow action path

* chore: update branch name

Co-authored-by: João Antunes <joao@netlify.com>

Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
  • Loading branch information
3 people committed Sep 13, 2021
1 parent 4c64157 commit a9b86e2
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions .github/workflows/e2e-nextjs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Next.js Integration test

on:
pull_request:
branches: [main]
# Run on release PRs only
paths: ['CHANGELOG.md']
branches: [main, 'chore/ci-e2e-nextjs']
# Run on release PRs only, or changes to this same file
paths: ['CHANGELOG.md', '.github/workflows/e2e-nextjs.yml']

jobs:
integration:
Expand Down Expand Up @@ -32,6 +32,11 @@ jobs:
with:
node-version: '*'
cache: 'npm'
# We need to add each of the lockfile paths so that the global npm cache is populated accordingly
cache-dependency-path: |
zip-it-and-ship-it/package-lock.json
netlify-plugin-nextjs/package-lock.json
netlify-cli/npm-shrinkwrap.json
- name: Installing netlify-cli
run: npm ci
working-directory: netlify-cli
Expand Down

1 comment on commit a9b86e2

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱ Benchmark results

largeDepsEsbuild: 11.1s

largeDepsZisi: 57.6s

Please sign in to comment.