chore(ci): fix our npm caching strategy for our e2e nextjs tests #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: chore
⏱ Benchmark resultsComparing with 4c64157 largeDepsEsbuild: 13s⬆️ 11.71% increase vs. 4c64157 Legend
largeDepsZisi: 1m 6.6s⬆️ 12.83% increase vs. 4c64157 Legend
|
| paths: ['CHANGELOG.md'] | ||
| branches: [main, 'chore/fix-ci-npm-cache'] | ||
| # Run on release PRs only, or changes to this same file | ||
| paths: ['CHANGELOG.md', '.github/workflows/e2e-nextjs.yml'] |
There was a problem hiding this comment.
Should we remove this change before merging?
There was a problem hiding this comment.
Actually, it kind of makes sense to run the CI when the workflow file changes, so maybe we should leave it?
There was a problem hiding this comment.
If folks agree with it I would keep both these changes ☝️ similart to what we have with fossa -https://github.com/netlify/zip-it-and-ship-it/blob/main/.github/workflows/fossa.yml#L6-L7 - this way we have the ability to always test this during dev if needed be?
There was a problem hiding this comment.
We could probably change the branch name though, maybe to something like chore/ci-e2e-nextjs? What do you think @eduardoboucas?
There was a problem hiding this comment.
Oh, I see. So you'll use that branch whenever you want to test the flow? Sounds good to me!
eduardoboucas
approved these changes
Sep 13, 2021
Co-authored-by: João Antunes <joao@netlify.com>
Next.js Integration Test (esbuild) |
Next.js Integration Test (default) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Similar to - netlify/cli#3277 - for our e2e tests seems like we clone a total of 3 projects. We need to make use of the
cache-dependency-pathproperty to point to each of the lockfiles individually (see here).- Test plan
- A picture of a cute animal (not mandatory but encouraged)