This repository has been archived by the owner on May 22, 2024. It is now read-only.
feat: convert Runtime, NodeBundler and ModuleFormat to enums #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: When using zip-it-and-ship-it with TS the types for the config and some return types changed. `nodeBundler` in the config, `moduleFormat` and `runtime` in return objects are now also enums. These const enums are exported in the main entry point for your use.
danez
added
type: feature
⏱ Benchmark resultsComparing with 850404d largeDepsEsbuild: 5.9s⬇️ 2.09% decrease vs. 850404d largeDepsNft: 27.6s⬆️ 0.03% increase vs. 850404d largeDepsZisi: 43s⬆️ 0.97% increase vs. 850404d |
Skn0tt
pushed a commit
to netlify/build
that referenced
this pull request
May 21, 2024
…/zip-it-and-ship-it#1179) BREAKING CHANGE: When using zip-it-and-ship-it with TS the types for the config and some return types changed. `nodeBundler` in the config, `moduleFormat` and `runtime` in return objects are now also enums. These const enums are exported in the main entry point for your use. Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
This is split out from #1173
This contains only the change to use enums for Runtime, Bundler, and ModuleFormat.
To be very semver correct, I marked this as breaking, because if someone uses this with typescript the update will be breaking for the types.