feat: replace acorn with @babel/parser #663

eduardoboucas · 2021-09-20T08:54:55Z

- Summary

With this PR, we'll use @babel/parser instead of acorn to parse imports with dynamic expressions.

The AST format is fairly similar, except for some deviations.

- Test plan

N/A

- A picture of a cute animal (not mandatory but encouraged)

Closes https://github.com/netlify/pod-serverless/issues/40.

github-actions · 2021-09-20T08:57:05Z

⏱ Benchmark results

Comparing with b843aae

largeDepsEsbuild: 11.3s

⬆️ 4.50% increase vs. b843aae

^          13.9s   13.9s                           14.1s   14.2s                                          
│           ┌──┐    ┌──┐                            ┌──┐    ┌──┐   13.5s   13.2s           13.3s          
│           |  |    |  |                   12.8s    |  |    |  |    ┌──┐    ┌──┐            ┌──┐          
│ ──────────┼──┼────┼──┼────────────────────┌──┐────┼──┼────┼──┼────┼──┼────┼──┼────────────┼──┼──────────
│           |  |    |  |   11.4s            |  |    |  |    |  |    |  |    |  |   11.1s    |  |   11.3s  
│           |  |    |  |    ┌──┐            |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    ┌──┐  
│  10.3s    |  |    |  |    |  |   10.1s    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (b843aae): 10.8s
T-29 (cdbcad2): 12.8s
T-28 (ff051cd): 11.8s
T-27 (c649c29): 12.5s
T-26 (9c628c8): 11.4s
T-25 (bf6a59b): 12.9s
T-24 (85cc47d): 13.4s
T-23 (b105692): 12.4s
T-22 (9b0c6d5): 10.6s
T-21 (53d0281): 12.2s
T-20 (b468b2a): 11.1s
T-19 (a9b86e2): 11.1s
T-18 (4c64157): 11.5s
T-17 (fbcb80f): 11.3s
T-16 (cde6c63): 12.4s
T-15 (c1e762d): 13.6s
T-14 (cc48969): 13s
T-13 (ce3c162): 13.7s
T-12 (fc6b3ef): 10.3s
T-11 (cde4e51): 13.9s
T-10 (cde2295): 13.9s
T-9 (e463691): 11.4s
T-8 (ecb8856): 10.1s
T-7 (73456ff): 12.8s
T-6 (452f7ee): 14.1s
T-5 (fcc82b7): 14.2s
T-4 (0862f9a): 13.5s
T-3 (8227298): 13.2s
T-2 (4bec0a7): 11.1s
T-1 (ccea887): 13.3s
T (current commit): 11.3s

largeDepsZisi: 59.6s

⬆️ 4.84% increase vs. b843aae

^         1m 13.5s1m 14.3s                                1m 14.8s                                        
│           ┌──┐    ┌──┐                          1m 10.9s  ┌──┐  1m 11.3s1m 9.5s         1m 12.5s        
│           |  |    |  |                  1m 7.8s   ┌──┐    |  |    ┌──┐    ┌──┐            ┌──┐          
│ ──────────┼──┼────┼──┼────────────────────┌──┐────┼──┼────┼──┼────┼──┼────┼──┼──1m 2.7s───┼──┼──────────
│           |  |    |  |                    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |   59.6s  
│           |  |    |  |   57.6s            |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐  
│  52.9s    |  |    |  |    ┌──┐   50.8s    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (b843aae): 56.7s
T-29 (cdbcad2): 1m 9s
T-28 (ff051cd): 1m 2.2s
T-27 (c649c29): 1m 4.8s
T-26 (9c628c8): 57.8s
T-25 (bf6a59b): 1m 10.4s
T-24 (85cc47d): 1m 10.1s
T-23 (b105692): 1m 7.2s
T-22 (9b0c6d5): 58s
T-21 (53d0281): 1m 5.7s
T-20 (b468b2a): 59.1s
T-19 (a9b86e2): 57.6s
T-18 (4c64157): 58s
T-17 (fbcb80f): 56.5s
T-16 (cde6c63): 1m 7.4s
T-15 (c1e762d): 1m 10.3s
T-14 (cc48969): 1m 8s
T-13 (ce3c162): 1m 11.6s
T-12 (fc6b3ef): 52.9s
T-11 (cde4e51): 1m 13.5s
T-10 (cde2295): 1m 14.3s
T-9 (e463691): 57.6s
T-8 (ecb8856): 50.8s
T-7 (73456ff): 1m 7.8s
T-6 (452f7ee): 1m 10.9s
T-5 (fcc82b7): 1m 14.8s
T-4 (0862f9a): 1m 11.3s
T-3 (8227298): 1m 9.5s
T-2 (4bec0a7): 1m 2.7s
T-1 (ccea887): 1m 12.5s
T (current commit): 59.6s

ehmicky

Looks good!
I checked for any Babel parser difference in dynamic_imports/parser.js and only found the one you changed (StringLiteral). 👍

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

feat: replace acorn with @babel/parser

fa7fc7e

eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Sep 20, 2021

eduardoboucas requested a review from netlify-team-account-1 September 20, 2021 08:54

netlify-team-account-1 approved these changes Sep 20, 2021

View reviewed changes

eduardoboucas requested a review from ehmicky September 20, 2021 11:12

ehmicky approved these changes Sep 20, 2021

View reviewed changes

eduardoboucas added the automerge label Sep 20, 2021

Merge branch 'main' into feat/replace-acorn-with-babel

d44a1ca

kodiakhq bot merged commit c28eaaf into main Sep 20, 2021

kodiakhq bot deleted the feat/replace-acorn-with-babel branch September 20, 2021 14:40

Skn0tt pushed a commit to netlify/build that referenced this pull request May 21, 2024

feat: replace acorn with @babel/parser (netlify/zip-it-and-ship-it#663)

7d0dc39

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: replace acorn with @babel/parser #663

feat: replace acorn with @babel/parser #663

eduardoboucas commented Sep 20, 2021

github-actions bot commented Sep 20, 2021 •

edited

ehmicky left a comment

feat: replace acorn with @babel/parser #663

feat: replace acorn with @babel/parser #663

Conversation

eduardoboucas commented Sep 20, 2021

github-actions bot commented Sep 20, 2021 • edited

⏱ Benchmark results

largeDepsEsbuild: 11.3s

largeDepsZisi: 59.6s

ehmicky left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 20, 2021 •

edited