fix: limit `nodeModulesWithDynamicImports` to unresolved imports #671

eduardoboucas · 2021-09-24T08:42:57Z

- Summary

Only adds modules to nodeModulesWithDynamicImports when the imports can't be resolved. More details in the linked issue.

Closes #627

- Test plan

Adjusted existing test

- A picture of a cute animal (not mandatory but encouraged)

github-actions · 2021-09-24T08:45:14Z

⏱ Benchmark results

Comparing with d646be2

largeDepsEsbuild: 12.4s

⬇️ 4.65% decrease vs. d646be2

^                                                  13.9s   13.9s                           14.1s          
│                  13.6s           13.7s            ┌──┐    ┌──┐                            ┌──┐          
│          12.4s    ┌──┐    13s     ┌──┐            |  |    |  |                   12.8s    |  |   12.4s  
│ ──────────┌──┐────┼──┼────┌──┐────┼──┼────────────┼──┼────┼──┼────────────────────┌──┐────┼──┼────┌──┐──
│  11.3s    |  |    |  |    |  |    |  |            |  |    |  |   11.4s            |  |    |  |    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    |  |   10.3s    |  |    |  |    ┌──┐            |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |   10.1s    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (d646be2): 13s
T-29 (2de5426): 12.8s
T-28 (f756b03): 12.6s
T-27 (5bf51d0): 12.2s
T-26 (c28eaaf): 11.6s
T-25 (b843aae): 10.8s
T-24 (cdbcad2): 12.8s
T-23 (ff051cd): 11.8s
T-22 (c649c29): 12.5s
T-21 (9c628c8): 11.4s
T-20 (bf6a59b): 12.9s
T-19 (85cc47d): 13.4s
T-18 (b105692): 12.4s
T-17 (9b0c6d5): 10.6s
T-16 (53d0281): 12.2s
T-15 (b468b2a): 11.1s
T-14 (a9b86e2): 11.1s
T-13 (4c64157): 11.5s
T-12 (fbcb80f): 11.3s
T-11 (cde6c63): 12.4s
T-10 (c1e762d): 13.6s
T-9 (cc48969): 13s
T-8 (ce3c162): 13.7s
T-7 (fc6b3ef): 10.3s
T-6 (cde4e51): 13.9s
T-5 (cde2295): 13.9s
T-4 (e463691): 11.4s
T-3 (ecb8856): 10.1s
T-2 (73456ff): 12.8s
T-1 (452f7ee): 14.1s
T (current commit): 12.4s

largeDepsZisi: 1m 8.2s

⬇️ 3.17% decrease vs. d646be2

^                                                 1m 13.5s1m 14.3s                                        
│                 1m 10.3s        1m 11.6s          ┌──┐    ┌──┐                          1m 10.9s        
│         1m 7.4s   ┌──┐   1m 8s    ┌──┐            |  |    |  |                  1m 7.8s   ┌──┐  1m 8.2s 
│ ──────────┌──┐────┼──┼────┌──┐────┼──┼────────────┼──┼────┼──┼────────────────────┌──┐────┼──┼────┌──┐──
│           |  |    |  |    |  |    |  |            |  |    |  |                    |  |    |  |    |▒▒|  
│  56.5s    |  |    |  |    |  |    |  |            |  |    |  |   57.6s            |  |    |  |    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    |  |   52.9s    |  |    |  |    ┌──┐   50.8s    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (d646be2): 1m 10.4s
T-29 (2de5426): 1m 9.5s
T-28 (f756b03): 1m 7.3s
T-27 (5bf51d0): 1m 5.8s
T-26 (c28eaaf): 1m 1.9s
T-25 (b843aae): 56.7s
T-24 (cdbcad2): 1m 9s
T-23 (ff051cd): 1m 2.2s
T-22 (c649c29): 1m 4.8s
T-21 (9c628c8): 57.8s
T-20 (bf6a59b): 1m 10.4s
T-19 (85cc47d): 1m 10.1s
T-18 (b105692): 1m 7.2s
T-17 (9b0c6d5): 58s
T-16 (53d0281): 1m 5.7s
T-15 (b468b2a): 59.1s
T-14 (a9b86e2): 57.6s
T-13 (4c64157): 58s
T-12 (fbcb80f): 56.5s
T-11 (cde6c63): 1m 7.4s
T-10 (c1e762d): 1m 10.3s
T-9 (cc48969): 1m 8s
T-8 (ce3c162): 1m 11.6s
T-7 (fc6b3ef): 52.9s
T-6 (cde4e51): 1m 13.5s
T-5 (cde2295): 1m 14.3s
T-4 (e463691): 57.6s
T-3 (ecb8856): 50.8s
T-2 (73456ff): 1m 7.8s
T-1 (452f7ee): 1m 10.9s
T (current commit): 1m 8.2s

…lify/zip-it-and-ship-it#671) * feat: limit nodeModulesWithDynamicImports to unresolved imports * chore: update test Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

feat: limit nodeModulesWithDynamicImports to unresolved imports

861ea63

eduardoboucas added the type: bug code to address defects in shipped code label Sep 24, 2021

eduardoboucas requested a review from netlify-team-account-1 September 24, 2021 08:42

chore: update test

422b1c0

eduardoboucas requested a review from ehmicky September 24, 2021 09:50

ehmicky approved these changes Sep 24, 2021

View reviewed changes

eduardoboucas added the automerge label Sep 27, 2021

Merge branch 'main' into feat/filter-dynamic-imports

6ddb91d

kodiakhq bot merged commit ce6d1ce into main Sep 27, 2021

kodiakhq bot deleted the feat/filter-dynamic-imports branch September 27, 2021 11:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: limit `nodeModulesWithDynamicImports` to unresolved imports #671

fix: limit `nodeModulesWithDynamicImports` to unresolved imports #671

eduardoboucas commented Sep 24, 2021

github-actions bot commented Sep 24, 2021 •

edited

fix: limit nodeModulesWithDynamicImports to unresolved imports #671

fix: limit nodeModulesWithDynamicImports to unresolved imports #671

Conversation

eduardoboucas commented Sep 24, 2021

github-actions bot commented Sep 24, 2021 • edited

⏱ Benchmark results

largeDepsEsbuild: 12.4s

largeDepsZisi: 1m 8.2s

fix: limit `nodeModulesWithDynamicImports` to unresolved imports #671

fix: limit `nodeModulesWithDynamicImports` to unresolved imports #671

github-actions bot commented Sep 24, 2021 •

edited