Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix largest values of same neighbors in move method #14

Closed
netotz opened this issue Feb 7, 2023 · 0 comments
Closed

Fix largest values of same neighbors in move method #14

netotz opened this issue Feb 7, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@netotz
Copy link
Owner

netotz commented Feb 7, 2023

Context

In Solver.move() method, the largest two values of same_neighbors dictionary are updated in the loop to retrieve them in constant time when calculating the objective function (best_out).

Bug

There's a missing condition to replace the second largest value when some value is less than the largest but greater than the second largest.

@netotz netotz added the bug Something isn't working label Feb 7, 2023
@netotz netotz self-assigned this Feb 7, 2023
@netotz netotz closed this as completed in e3814df May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant