New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect() in component does not respect server port #164

Open
novotnej opened this Issue Oct 31, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@novotnej

novotnej commented Oct 31, 2016

I am running Nette 2.4 in docker with nginx and PHP 7.0.12. Docker is internally listening on port 666, port 80 is exposed (works fine when both are 666)

Specific scenario: processing form inside a component that's created using a factory injected to a presenter.

$form->onSuccess[] = function(Form $form) {
    $this->presenter->redirect('Listing:default', ['filter' => $form->getValues(true)]);
};

This will try to re-direct to :666/listing?filter= ...
And while I could resolve this simply by using same ports (80:80), I am a bit afraid what it would do when using https and also once it's set up behind a load balancer or a proxy.

Also might be worth investigating whether sessions will be stored properly in regard to the domain the user actually accessed (rather than domain where the instance is physically running) - this might potentially be a big issue..

Thank you for checking this out!

@dg

This comment has been minimized.

Member

dg commented May 29, 2018

Can you fix it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment