Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestCase::prepareTestData(): Data provider validation must be inside foreach. #431

Closed
wants to merge 3 commits into from

Conversation

janbarasek
Copy link
Contributor

  • bug fix
  • BC break? no

Validation must be inside foreach, because this code is not valid input, but original will ignore it:

Snímek obrazovky 2021-04-06 v 21 39 44

Thanks.

@janbarasek
Copy link
Contributor Author

janbarasek commented Apr 6, 2021

I am not sure how to add tests for this bugfix. :/

@milo milo closed this in 03c5064 Aug 24, 2021
dg pushed a commit that referenced this pull request Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant