Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icons too big in 2.6.3 #371

Closed
jkavalik opened this issue Jun 19, 2019 · 7 comments
Closed

Icons too big in 2.6.3 #371

jkavalik opened this issue Jun 19, 2019 · 7 comments

Comments

@jkavalik
Copy link

jkavalik commented Jun 19, 2019

After 2.6.3 update the tracy bar somehow inflated:
2.6.2
Snímek obrazovky pořízený 2019-06-19 09-44-47
2.6.3
Snímek obrazovky pořízený 2019-06-19 09-44-56

It returns to normal if I disable either width: initial; or height: initial; from 1990958

@Gappa
Copy link

Gappa commented Jun 19, 2019

Seeing it too for Kdyby/Translation. The culprit is this part in the reset css:

#tracy-debug * {
...
height: initial;
}

The height attribute is then ignored (16 px) and the real value is used (32 px).

Edit - Possible fix:

#tracy-debug-bar img {
   ...
    max-width: 1.23em;
    max-height: 1.55em;
}

Values used are from svg selector, just swapped for "max" variants.

@dg
Copy link
Member

dg commented Jun 20, 2019

Do you mean that HTML attribute height="16px" is ignored?

@Gappa
Copy link

Gappa commented Jun 20, 2019

Not exactly ignored, but overruled by height: initial declaration.

@jkavalik
Copy link
Author

Snímek obrazovky pořízený 2019-06-21 10-04-47
(Chrome 73.0.3683.86, Ubuntu 16.04)

@dg
Copy link
Member

dg commented Jun 25, 2019

I simply can't understand how can global style (without !important) override inline style 🤯

@jkavalik
Copy link
Author

@dg well, it is not an inline style but a html attribute. And they are overriden by css according to https://www.w3.org/TR/CSS21/cascade.html#preshint

@dg
Copy link
Member

dg commented Jun 25, 2019

Oh, I see it!

@dg dg closed this as completed in 2dbc5ad Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants