Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upStrings: throw exception on malformed UTF-8 in webalize() and toAscii() #205
Conversation
This comment has been minimized.
This comment has been minimized.
|
Travis failures seem to be unrelated to this PR. |
VasekPurchart
force-pushed the
VasekPurchart:webalize-malformed-utf
branch
from
e60b3b3
to
8eaf2ec
This comment has been minimized.
This comment has been minimized.
|
Thanks |
This comment has been minimized.
This comment has been minimized.
|
@dg Thanks for merging. As for the other places in Strings where the native |
This comment has been minimized.
This comment has been minimized.
|
I did it 6339ca2 |
This comment has been minimized.
This comment has been minimized.
|
Great, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
VasekPurchart commentedDec 2, 2019
•
edited
Since
Strings::webalize()can be called on user input it should be able to deal with anything or error in a predicable way. But when an malformed UTF-8 input is given currently it results in:(i guess this behaved differently before scrict types were added in 3.0.0).
Throwing an exception (the same exception as in other cases such as
Strings::replace()) seems reasonable to me.I am also not sure why the internal handling of PCRE is not used everywhere in calling
preg_*is not used everywhere in the file, because there might be of course other problems too?