Add TimedOutTestsListener to print the full thread dump on test timeout #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @trustin |
|
|
||
| static final String TEST_TIMED_OUT_PREFIX = "test timed out after"; | ||
|
|
||
| private static String INDENT = " "; |
There was a problem hiding this comment.
I guess this could be translated to: missing final
There was a problem hiding this comment.
and.. how about using '\t' instead? It seems like Throwable.printStackTrace() indents with a tab.
|
Global comment: Please use 4-space indentation like we do in netty/netty |
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.netty.build.test; |
There was a problem hiding this comment.
How about io.netty.build.junit?
|
Updated |
windie
force-pushed
the
timeout-listener
branch
from
c7b33d7
to
721955a
Compare
|
LGTM. Please squash so I can cherry-pick. Thanks! |
Motivation: See netty/netty#3172 Modifications: Copy TimedOutTestsListener from https://github.com/apache/hadoop/blob/18f9b77a321b225677ce23c503b41d21478fc4a7/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TimedOutTestsListener.java Result: If a test is set the timeout parameter using junit's @test(timeout = ...) and the timeout is triggered, a full stack trace dump will be outputted and also output the deadlocks if any.
windie
force-pushed
the
timeout-listener
branch
from
721955a
to
10a8f73
Compare
|
squashed |
|
@trustin Will you release soon? I can submit a PR for netty to add this timeout listener after that. |
|
ping @trustin |
|
Thanks for your patient. Cherry-picked: d513280 Will perform the release process and add a comment here when it's out. |
|
Finished the release process. Should appear in the central repository in 30 minutes. |
windie
added a commit
to windie/netty
that referenced
this pull request
Mar 4, 2016
Motivation: See netty#3172 Modifications: netty/netty-build#6 added a junit timeout listener to the netty-build project. This patch just set it up. Result: If a test is set the timeout parameter using junit's @test(timeout = ...) and the timeout is triggered, a full stack trace dump will be outputted and also output the deadlocks if any.
normanmaurer
pushed a commit
to netty/netty
that referenced
this pull request
Mar 4, 2016
Motivation: See #3172 Modifications: netty/netty-build#6 added a junit timeout listener to the netty-build project. This patch just set it up. Result: If a test is set the timeout parameter using junit's @test(timeout = ...) and the timeout is triggered, a full stack trace dump will be outputted and also output the deadlocks if any.
normanmaurer
pushed a commit
to netty/netty
that referenced
this pull request
Mar 4, 2016
Motivation: See #3172 Modifications: netty/netty-build#6 added a junit timeout listener to the netty-build project. This patch just set it up. Result: If a test is set the timeout parameter using junit's @test(timeout = ...) and the timeout is triggered, a full stack trace dump will be outputted and also output the deadlocks if any.
pulllock
pushed a commit
to pulllock/netty
that referenced
this pull request
Oct 19, 2023
Motivation: See netty#3172 Modifications: netty/netty-build#6 added a junit timeout listener to the netty-build project. This patch just set it up. Result: If a test is set the timeout parameter using junit's @test(timeout = ...) and the timeout is triggered, a full stack trace dump will be outputted and also output the deadlocks if any.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
See netty/netty#3172
Modifications:
Copy TimedOutTestsListener from https://github.com/apache/hadoop/blob/18f9b77a321b225677ce23c503b41d21478fc4a7/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TimedOutTestsListener.java
Result:
If a test is set the timeout parameter using junit's @test(timeout = ...) and the timeout is triggered, a full stack trace dump will be outputted and also output the deadlocks if any.