Add TimedOutTestsListener to print the full thread dump on test timeout #4749
Conversation
Motivation: See netty#3172 Modifications: Copy TimedOutTestsListener from Apache Hadoop(https://github.com/apache/hadoop/blob/d1c6accb6f87b08975175580e15f1ff1fe29ab04/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TimedOutTestsListener.java) into the "common" project and add `output.flush()`. If not calling `flush`, the output may be printed to the console. In addition, also update the `pom.xml`s to set up the timeout listener. This is a workaround before junit adds such listener (junit-team/junit4#463). Result: If a test is set the timeout paramter using junit's `@Test(timeout = ...)` and the timeout is triggered, a full stack trace dump will be outputted and also output the deadlocks if any.
|
From the CI log, looks it doesn't run |
| @@ -0,0 +1,175 @@ | |||
| /* | |||
| * Copyright 2012 The Netty Project | |||
There was a problem hiding this comment.
2016?
Also should there be another license from the original source code (assuming this was forked from somewhere else)?
|
@Scottmitch - do you know how to fix the build issue? |
|
@windie - I would need to investigate. However see https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html:
|
|
@Scottmitch - Yeah, but it's talking about a separate project, not module. I cannot find an approach to avoid so many verbose dependencies in the same project. I think it's better to put this one in the netty project. |
|
@windie How about netty/netty-build? https://github.com/netty/netty-build We have some generic build-related stuff there so it's probably better putting it there as well. |
|
Closed. Submit netty/netty-build#6 instead. |
Motivation:
See #3172
Modifications:
Copy TimedOutTestsListener from Apache Hadoop(https://github.com/apache/hadoop/blob/d1c6accb6f87b08975175580e15f1ff1fe29ab04/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/test/TimedOutTestsListener.java) into the "common" project and add
output.flush(). If not callingflush, the output may be printed to the console.In addition, also update the
pom.xmls to set up the timeout listener.This is a workaround before junit adds such listener (junit-team/junit4#463).
Result:
If a test is set the timeout paramter using junit's
@Test(timeout = ...)and the timeout is triggered, a full stack trace dump will be outputted and also output the deadlocks if any.