Allow to use KeyManagerFactory / TrustmanagerFactory #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normanmaurer
force-pushed
the
inject_ssl
branch
from
6eabcdf
to
e31e1c9
Compare
|
We can simplify some of this when netty/netty#10953 is merged |
normanmaurer
added a commit
to netty/netty
that referenced
this pull request
Jan 21, 2021
Motivation: Creating certificates from a byte[] while lazy parse it is general useful and is also needed by netty/netty-incubator-codec-quic#141 Modifications: Move classes, rename these and make them public Result: Be able to reuse code
normanmaurer
added a commit
to netty/netty
that referenced
this pull request
Jan 21, 2021
Motivation: Creating certificates from a byte[] while lazy parse it is general useful and is also needed by netty/netty-incubator-codec-quic#141 Modifications: Move classes, rename these and make them public Result: Be able to reuse code
normanmaurer
force-pushed
the
inject_ssl
branch
10 times, most recently
from
0dcc4d0
to
e07133f
Compare
Motivation: People often want to use their own custom keymaterial selection / certificate validation. This was not possible as all of this was handled internally by quiche. Modification: - Allow to implement custom key material selection - Allow to implement custom certificate validation - Port over some code from netty-tcnative / netty - Use our own vendored boringssl libraries when compiling Result: Fixes #97
normanmaurer
force-pushed
the
inject_ssl
branch
from
c898c1a
to
70d6d84
Compare
ZzxyNn
pushed a commit
to ZzxyNn/netty
that referenced
this pull request
Jan 29, 2021
Motivation: Creating certificates from a byte[] while lazy parse it is general useful and is also needed by netty/netty-incubator-codec-quic#141 Modifications: Move classes, rename these and make them public Result: Be able to reuse code
normanmaurer
added a commit
to netty/netty
that referenced
this pull request
Mar 7, 2021
Motivation: Creating certificates from a byte[] while lazy parse it is general useful and is also needed by netty/netty-incubator-codec-quic#141 Modifications: Move classes, rename these and make them public Result: Be able to reuse code
raidyue
pushed a commit
to raidyue/netty
that referenced
this pull request
Jul 8, 2022
Motivation: Creating certificates from a byte[] while lazy parse it is general useful and is also needed by netty/netty-incubator-codec-quic#141 Modifications: Move classes, rename these and make them public Result: Be able to reuse code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
People often want to use their own custom keymaterial selection / certificate validation. This was not possible as all of this was handled internally by quiche.
Modification:
Result:
Fixes #97