Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark some methods as protected to make it easier to write own SslCont… #10953

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

normanmaurer
Copy link
Member

…ext implementations

Motivation:

We should expose some methods as protected to make it easier to write custom SslContext implementations.
This will be reused by the code for netty/netty-incubator-codec-quic#97

Modifications:

  • Add protected to some static methods which are useful for sub-classes
  • Remove some unused methods
  • Move *Wrapper classes to util package and make these public

Result:

Easier to write custom SslContext implementations

…ext implementations

Motivation:

We should expose some methods as protected to make it easier to write custom SslContext implementations.
This will be reused by the code for netty/netty-incubator-codec-quic#97

Modifications:

- Add protected to some static methods which are useful for sub-classes
- Remove some unused methods
- Move *Wrapper classes to util package and make these public

Result:

Easier to write custom SslContext implementations
Copy link
Contributor

@chrisvest chrisvest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one thing I don't understand.

@normanmaurer normanmaurer merged commit ae3eebf into 4.1 Jan 21, 2021
@normanmaurer normanmaurer deleted the ssl_context branch January 21, 2021 09:41
normanmaurer added a commit that referenced this pull request Jan 21, 2021
…ext implementations (#10953)

Motivation:

We should expose some methods as protected to make it easier to write custom SslContext implementations.
This will be reused by the code for netty/netty-incubator-codec-quic#97

Modifications:

- Add protected to some static methods which are useful for sub-classes
- Remove some unused methods
- Move *Wrapper classes to util package and make these public

Result:

Easier to write custom SslContext implementations
ZzxyNn pushed a commit to ZzxyNn/netty that referenced this pull request Jan 29, 2021
…ext implementations (netty#10953)

Motivation:

We should expose some methods as protected to make it easier to write custom SslContext implementations.
This will be reused by the code for netty/netty-incubator-codec-quic#97

Modifications:

- Add protected to some static methods which are useful for sub-classes
- Remove some unused methods
- Move *Wrapper classes to util package and make these public

Result:

Easier to write custom SslContext implementations
raidyue pushed a commit to raidyue/netty that referenced this pull request Jul 8, 2022
…ext implementations (netty#10953)

Motivation:

We should expose some methods as protected to make it easier to write custom SslContext implementations.
This will be reused by the code for netty/netty-incubator-codec-quic#97

Modifications:

- Add protected to some static methods which are useful for sub-classes
- Remove some unused methods
- Move *Wrapper classes to util package and make these public

Result:

Easier to write custom SslContext implementations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants