Ensure QuicheQuicChannel is always removed from the QuicheQuicChannel… #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Set Motivation: We need to ensure that the QuicheQuicChannel is always removed from the Set as otherwise it will never be GC'ed and so we will "leak" memory and eventual OOME. Beside this we also should only schedule a timeout if the returned nanos are positive and not Long.MAX_VALUE. Modifications: - Correctly remove QuicheQuicChannel from Set when the native connection is freed. - Handle nanos correctly when schedule timeout task. - Refactor code to hide stuff as much as possible from sub-classes - Add asserts to ensure the code works as expected Result: No more OOME caused by "leaking" QuicheQuicChannel in Set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… Set
Motivation:
We need to ensure that the QuicheQuicChannel is always removed from the Set as otherwise it will never be GC'ed and so we will "leak" memory and eventual OOME. Beside this we also should only schedule a timeout if the returned nanos are positive and not Long.MAX_VALUE.
Modifications:
Result:
No more OOME caused by "leaking" QuicheQuicChannel in Set.