Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure QuicheQuicChannel is always removed from the QuicheQuicChannel… #660

Merged
merged 1 commit into from Feb 5, 2024

Commits on Feb 5, 2024

  1. Ensure QuicheQuicChannel is always removed from the QuicheQuicChannel…

    … Set
    
    Motivation:
    
    We need to ensure that the QuicheQuicChannel is always removed from the Set as otherwise it will never be GC'ed and so we will "leak" memory and eventual OOME.
    Beside this we also should only schedule a timeout if the returned nanos are positive and not Long.MAX_VALUE.
    
    Modifications:
    
    - Correctly remove QuicheQuicChannel from Set when the native connection is freed.
    - Handle nanos correctly when schedule timeout task.
    - Refactor code to hide stuff as much as possible from sub-classes
    - Add asserts to ensure the code works as expected
    
    Result:
    
    No more OOME caused by "leaking" QuicheQuicChannel in Set.
    normanmaurer committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    7418ed6 View commit details
    Browse the repository at this point in the history