Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibreSSL workaround for unsupported X509_V_ERR_UNSPECIFIED #234

Closed
wants to merge 1 commit into from
Closed

LibreSSL workaround for unsupported X509_V_ERR_UNSPECIFIED #234

wants to merge 1 commit into from

Conversation

Scottmitch
Copy link
Member

Motivation:
LibreSSL 2.4.x does not support X509_V_ERR_UNSPECIFIED. Until we update to LibreSSL 2.5.x we need to introduce a work around for lack of support for X509_V_ERR_UNSPECIFIED.

Modifications:

  • Use X509_V_ERR_CERT_REJECTED for LibreSSL instead of X509_V_ERR_UNSPECIFIED.

Result:
We can compile with LibreSSL 2.4.x.

@Scottmitch Scottmitch added this to the 2.0.0.Final milestone Feb 14, 2017
@Scottmitch Scottmitch self-assigned this Feb 14, 2017
@Scottmitch
LibreSSL workaround for unsupported X509_V_ERR_UNSPECIFIED
6f9c183 
Motivation:
LibreSSL 2.4.x does not support X509_V_ERR_UNSPECIFIED. Until we update to LibreSSL 2.5.x we need to introduce a work around for lack of support for X509_V_ERR_UNSPECIFIED.

Modifications:
- Use X509_V_ERR_CERT_REJECTED for LibreSSL instead of X509_V_ERR_UNSPECIFIED.

Result:
We can compile with LibreSSL 2.4.x.
@normanmaurer
Copy link
Member

Ship it!

@Scottmitch
Copy link
Member Author

master (0a010b6)

@Scottmitch Scottmitch closed this Feb 14, 2017
@Scottmitch Scottmitch mentioned this pull request Feb 14, 2017
Closed
@Scottmitch Scottmitch deleted the libressl_workaround branch February 14, 2017 19:49
@normanmaurer normanmaurer modified the milestones: 2.0.0.Final, 2.0.0.Beta2 Feb 15, 2017
normanmaurer added a commit that referenced this pull request Jun 8, 2019
@normanmaurer
Remove hack used to support old versions of libressl
7c228b3 
Motivation:

At some point we introduced a hack to be able to compile against libressl 2.4.x. As we now use libressl 2.9 we can just remove the hack and cleanup the code-base.

See #234.

Modifications:

Remove hack and just use X509_V_ERR_UNSPECIFIED directly.

Result:

Fixes #235
@normanmaurer normanmaurer mentioned this pull request Jun 8, 2019
Closed
normanmaurer added a commit that referenced this pull request Jun 9, 2019
@normanmaurer
Remove hack used to support old versions of libressl
8472ea1 
Motivation:

At some point we introduced a hack to be able to compile against libressl 2.4.x. As we now use libressl 2.9 we can just remove the hack and cleanup the code-base.

See #234.

Modifications:

Remove hack and just use X509_V_ERR_UNSPECIFIED directly.

Result:

Fixes #235
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanmaurer normanmaurer normanmaurer approved these changes

Assignees

@Scottmitch Scottmitch

Labels
cleanup
Projects
None yet
Milestone
2.0.0.Beta3
Development

Successfully merging this pull request may close these issues.
2 participants
@Scottmitch @normanmaurer