Skip to content

Commit

Permalink
NIO ServerChannel shouldn't close because of Exception
Browse files Browse the repository at this point in the history
Motivation:
e102a00 changed a conditional where previously the NIO ServerChannel would not be closed in the event of an exception.

Modifications:
- Restore the logic prior to e102a00 which does not automatically close ServerChannels for IOExceptions

Result:
NIO ServerChannel doesn't close automatically for an IOException.
  • Loading branch information
Scottmitch committed Dec 6, 2016
1 parent eed6791 commit 002c99e
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -176,7 +176,7 @@ protected boolean closeOnReadError(Throwable cause) {
// accepting incoming connections. (e.g. too many open files)
return cause instanceof IOException &&
!(cause instanceof PortUnreachableException) &&
this instanceof ServerChannel;
!(this instanceof ServerChannel);
}

/**
Expand Down

0 comments on commit 002c99e

Please sign in to comment.