Cleanup after commit fc1cdc9

netty · Dec 5, 2016 · eed6791 · eed6791
1 parent 13a8eba
commit eed6791
Showing 1 changed file with 23 additions and 31 deletions.
diff --git a/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java b/transport/src/main/java/io/netty/channel/nio/NioEventLoop.java
@@ -39,7 +39,6 @@
 import java.security.PrivilegedAction;
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.ConcurrentModificationException;
 import java.util.Iterator;
 import java.util.Queue;
 import java.util.Set;
@@ -339,35 +338,32 @@ private void rebuildSelector0() {
 
         // Register all channels to the new Selector.
         int nChannels = 0;
-        for (;;) {
-            for (SelectionKey key: oldSelector.keys()) {
-                Object a = key.attachment();
-                try {
-                    if (!key.isValid() || key.channel().keyFor(newSelector) != null) {
-                        continue;
-                    }
+        for (SelectionKey key: oldSelector.keys()) {
+            Object a = key.attachment();
+            try {
+                if (!key.isValid() || key.channel().keyFor(newSelector) != null) {
+                    continue;
+                }
 
-                    int interestOps = key.interestOps();
-                    key.cancel();
-                    SelectionKey newKey = key.channel().register(newSelector, interestOps, a);
-                    if (a instanceof AbstractNioChannel) {
-                        // Update SelectionKey
-                        ((AbstractNioChannel) a).selectionKey = newKey;
-                    }
-                    nChannels ++;
-                } catch (Exception e) {
-                    logger.warn("Failed to re-register a Channel to the new Selector.", e);
-                    if (a instanceof AbstractNioChannel) {
-                        AbstractNioChannel ch = (AbstractNioChannel) a;
-                        ch.unsafe().close(ch.unsafe().voidPromise());
-                    } else {
-                        @SuppressWarnings("unchecked")
-                        NioTask<SelectableChannel> task = (NioTask<SelectableChannel>) a;
-                        invokeChannelUnregistered(task, key, e);
-                    }
+                int interestOps = key.interestOps();
+                key.cancel();
+                SelectionKey newKey = key.channel().register(newSelector, interestOps, a);
+                if (a instanceof AbstractNioChannel) {
+                    // Update SelectionKey
+                    ((AbstractNioChannel) a).selectionKey = newKey;
+                }
+                nChannels ++;
+            } catch (Exception e) {
+                logger.warn("Failed to re-register a Channel to the new Selector.", e);
+                if (a instanceof AbstractNioChannel) {
+                    AbstractNioChannel ch = (AbstractNioChannel) a;
+                    ch.unsafe().close(ch.unsafe().voidPromise());
+                } else {
+                    @SuppressWarnings("unchecked")
+                    NioTask<SelectableChannel> task = (NioTask<SelectableChannel>) a;
+                    invokeChannelUnregistered(task, key, e);
                 }
             }
-            break;
         }
 
         selector = newSelector;
@@ -644,10 +640,6 @@ private void processSelectedKey(SelectionKey k, AbstractNioChannel ch) {
             // to a spin loop
             if ((readyOps & (SelectionKey.OP_READ | SelectionKey.OP_ACCEPT)) != 0 || readyOps == 0) {
                 unsafe.read();
-                if (!ch.isOpen()) {
-                    // Connection already closed - no need to handle write.
-                    return;
-                }
             }
         } catch (CancelledKeyException ignored) {
             unsafe.close(unsafe.voidPromise());