Skip to content

Commit

Permalink
netty-all should not re-package jars (#11732)
Browse files Browse the repository at this point in the history
Motivation:

As of today our netty-all artifact does just re-package classes / native libs that are included in our other modules. This can result in all kind of different issues especially if some people have netty-all and other netty-* modules on the classpath.

Modifications:

- Change netty-all to not re-package but just depend on the other different modules
- Use the flatten plugin to ensure the correct dependencies are added to the final pom.xml and the optional dependencies are excluded
- Adjust profiles
- Adjust release scripts

Result:

netty-all does not repackage and just pulls in its dependencies.

Result:

After your change, what will change.
  • Loading branch information
normanmaurer committed Oct 7, 2021
1 parent bc13595 commit 04f0eed
Show file tree
Hide file tree
Showing 3 changed files with 75 additions and 424 deletions.
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,6 @@ mainframer
# exclude vscode files
.vscode/
*.factorypath

# exclude file created by the flatten plugin
.flattened-pom.xml

0 comments on commit 04f0eed

Please sign in to comment.