Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Throw correct NotYetConnectedException when ENOTCONN errno is set
Motivation: We should throw a NotYetConnectedException when ENOTCONN errno is set. This is also consistent with NIO. Modification: Throw correct exception and add test case Result: More correct and consistent behavior.
- Loading branch information
1 parent
43626ac
commit 2c1f17f
Showing
5 changed files
with
101 additions
and
20 deletions.
There are no files selected for viewing
63 changes: 63 additions & 0 deletions
63
...e/src/main/java/io/netty/testsuite/transport/socket/SocketChannelNotYetConnectedTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
/* | ||
* Copyright 2016 The Netty Project | ||
* | ||
* The Netty Project licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package io.netty.testsuite.transport.socket; | ||
|
||
import io.netty.bootstrap.Bootstrap; | ||
import io.netty.channel.ChannelInboundHandlerAdapter; | ||
import io.netty.channel.socket.SocketChannel; | ||
import org.junit.Test; | ||
|
||
import java.net.InetSocketAddress; | ||
import java.net.SocketException; | ||
import java.nio.channels.NotYetConnectedException; | ||
|
||
import static org.junit.Assert.fail; | ||
|
||
public class SocketChannelNotYetConnectedTest extends AbstractClientSocketTest { | ||
@Test(timeout = 30000) | ||
public void testShutdownNotYetConnected() throws Throwable { | ||
run(); | ||
} | ||
|
||
public void testShutdownNotYetConnected(Bootstrap cb) throws Throwable { | ||
SocketChannel ch = (SocketChannel) cb.handler(new ChannelInboundHandlerAdapter()) | ||
.bind(new InetSocketAddress(0)).syncUninterruptibly().channel(); | ||
try { | ||
try { | ||
ch.shutdownInput().syncUninterruptibly(); | ||
fail(); | ||
} catch (Throwable cause) { | ||
checkThrowable(cause); | ||
} | ||
|
||
try { | ||
ch.shutdownOutput().syncUninterruptibly(); | ||
fail(); | ||
} catch (Throwable cause) { | ||
checkThrowable(cause); | ||
} | ||
} finally { | ||
ch.close().syncUninterruptibly(); | ||
} | ||
} | ||
|
||
private static void checkThrowable(Throwable cause) throws Throwable { | ||
// Depending on OIO / NIO both are ok | ||
if (!(cause instanceof NotYetConnectedException) && !(cause instanceof SocketException)) { | ||
throw cause; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
...ive-epoll/src/test/java/io/netty/channel/epoll/EpollSocketChannelNotYetConnectedTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
/* | ||
* Copyright 2016 The Netty Project | ||
* | ||
* The Netty Project licenses this file to you under the Apache License, | ||
* version 2.0 (the "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at: | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
package io.netty.channel.epoll; | ||
|
||
import io.netty.bootstrap.Bootstrap; | ||
import io.netty.testsuite.transport.TestsuitePermutation; | ||
import io.netty.testsuite.transport.socket.SocketChannelNotYetConnectedTest; | ||
|
||
import java.util.List; | ||
|
||
public class EpollSocketChannelNotYetConnectedTest extends SocketChannelNotYetConnectedTest { | ||
@Override | ||
protected List<TestsuitePermutation.BootstrapFactory<Bootstrap>> newFactories() { | ||
return EpollSocketTestPermutation.INSTANCE.clientSocket(); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters