Skip to content

Commit

Permalink
Change the default value of maxMessagePerRead to 16 in ChannelMetadata (
Browse files Browse the repository at this point in the history
#13680)

Motivation:

We used 1 as the default value for maxMessagesPerRead in ChannelMetadata
which is a very bad default for performance reasons. Because of this we
usually explicit use 16 when constructing it. To eliminate problems when
we forgot to do so let's use 16 as default.

Modifications:

Change default to 16

Result:

Better performance by default
  • Loading branch information
normanmaurer committed Nov 2, 2023
1 parent af9ba8d commit 5a98214
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public final class ChannelMetadata {
* again, such as UDP/IP.
*/
public ChannelMetadata(boolean hasDisconnect) {
this(hasDisconnect, 1);
this(hasDisconnect, 16);
}

/**
Expand Down

0 comments on commit 5a98214

Please sign in to comment.