Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module compatibility #11567

Closed
jameskleeh opened this issue Aug 10, 2021 · 6 comments · Fixed by #11609
Closed

Module compatibility #11567

jameskleeh opened this issue Aug 10, 2021 · 6 comments · Fixed by #11609
Milestone
4.1.68.Final

Comments

@jameskleeh
Copy link
Contributor

Netty 4.1.66 introduced a requirement on tc-native 2.0.40 with this commit 40fb602

This led to a user being confronted with an error after upgrading Micronaut (which includes 4.1.66) micronaut-projects/micronaut-core#5920

Can we get the tc-native modules added to the netty bom so we can avoid this?
@jameskleeh jameskleeh mentioned this issue Aug 10, 2021
Closed
@normanmaurer
Copy link
Member

@jameskleeh I am currently not sure how to do this as the user can either use netty-tcnative or netty-tcnative-boringssl-static. Or you are saying we should add both ?

@jameskleeh
Copy link
Contributor Author

Yeah I think both

@normanmaurer
Copy link
Member

@jameskleeh want to provide a PR ?

@jameskleeh
Copy link
Contributor Author

Sure

@normanmaurer normanmaurer added this to the 4.1.68.Final milestone Aug 16, 2021
@normanmaurer
Copy link
Member

@jameskleeh ping me once something is ready for review

normanmaurer added a commit that referenced this issue Aug 23, 2021
@normanmaurer
Add netty-bom-ssl which defines the version for netty-tcnative-boring…
7ba53b4 
…ssl-static

Motivation:

Keeping the version of netty-tcnative correct can sometimes be hard.

Modifications:

Add a netty-bom-ssl which provides the correct netty-tcnative-boringssl-static version and so makes it easier for people to use the correct version

Result:

Fixes #11567
@normanmaurer normanmaurer mentioned this issue Aug 23, 2021
Merged
@normanmaurer
Copy link
Member

@jameskleeh #11609

normanmaurer added a commit that referenced this issue Aug 23, 2021
@normanmaurer
Add version for netty-tcnative* to bom
27714e7 
Motivation:

Keeping the version of netty-tcnative correct can sometimes be hard.

Modifications:

Add entries for netty-tcnative* to the bom

Result:

Fixes #11567
normanmaurer added a commit that referenced this issue Aug 25, 2021
@normanmaurer
Add version for netty-tcnative* to bom (#11609)
5e7eb37 
Motivation:

Keeping the version of netty-tcnative correct can sometimes be hard.

Modifications:

Add entries for netty-tcnative* to the bom

Result:

Fixes #11567
normanmaurer added a commit that referenced this issue Aug 25, 2021
@normanmaurer
Add version for netty-tcnative* to bom (#11609)
a34b440 
Motivation:

Keeping the version of netty-tcnative correct can sometimes be hard.

Modifications:

Add entries for netty-tcnative* to the bom

Result:

Fixes #11567
laosijikaichele pushed a commit to laosijikaichele/netty that referenced this issue Dec 16, 2021
@normanmaurer @laosijikaichele
Add version for netty-tcnative* to bom (netty#11609)
ae3d0f3 
Motivation:

Keeping the version of netty-tcnative correct can sometimes be hard.

Modifications:

Add entries for netty-tcnative* to the bom

Result:

Fixes netty#11567
laosijikaichele pushed a commit to laosijikaichele/netty that referenced this issue Dec 16, 2021
@normanmaurer @laosijikaichele
Add version for netty-tcnative* to bom (netty#11609)
acb0ced 
Motivation:

Keeping the version of netty-tcnative correct can sometimes be hard.

Modifications:

Add entries for netty-tcnative* to the bom

Result:

Fixes netty#11567
raidyue pushed a commit to raidyue/netty that referenced this issue Jul 8, 2022
@normanmaurer
Add version for netty-tcnative* to bom (netty#11609)
88fd851 
Motivation:

Keeping the version of netty-tcnative correct can sometimes be hard.

Modifications:

Add entries for netty-tcnative* to the bom

Result:

Fixes netty#11567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.68.Final
Development

Successfully merging a pull request may close this issue.

Add version for netty-tcnative* to bom netty/netty
2 participants
@normanmaurer @jameskleeh